lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] doc: filesystems: format tables in locking properly
Date
Commit 28df3d1539de ("nfsd: clients don't need to break their own
delegations") introduced lm_breaker_owns_lease and documented that in the
according table. Commit 43dbd0e7e62b ("mmap locking API: convert mmap_sem
comments") renamed mmap_sem to mmap_lock in another table. Both changes
created a table entry longer than the content before, but did not adjust
the tables. Hence, make htmldocs warns about malformed tables.

Adjust the tables to address the warning.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Michel, Vlastimil, please ack this patch.

Andrew, please pick this minor doc fix patch into your -next tree, where
patch "mmap locking API: convert mmap_sem comments" has been applied.


Documentation/filesystems/locking.rst | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
index 318605de83f3..faf7f4abd54d 100644
--- a/Documentation/filesystems/locking.rst
+++ b/Documentation/filesystems/locking.rst
@@ -433,15 +433,15 @@ prototypes::

locking rules:

-========== ============= ================= =========
-ops inode->i_lock blocked_lock_lock may block
-========== ============= ================= =========
-lm_notify: yes yes no
-lm_grant: no no no
-lm_break: yes no no
-lm_change yes no no
-lm_breaker_owns_lease: no no no
-========== ============= ================= =========
+====================== ============= ================= =========
+ops inode->i_lock blocked_lock_lock may block
+====================== ============= ================= =========
+lm_notify: yes yes no
+lm_grant: no no no
+lm_break: yes no no
+lm_change yes no no
+lm_breaker_owns_lease: no no no
+====================== ============= ================= =========

buffer_head
===========
@@ -616,9 +616,9 @@ prototypes::

locking rules:

-============= ======== ===========================
+============= ========= ===========================
ops mmap_lock PageLocked(page)
-============= ======== ===========================
+============= ========= ===========================
open: yes
close: yes
fault: yes can return with page locked
@@ -626,7 +626,7 @@ map_pages: yes
page_mkwrite: yes can return with page locked
pfn_mkwrite: yes
access: yes
-============= ======== ===========================
+============= ========= ===========================

->fault() is called when a previously not present pte is about
to be faulted in. The filesystem must find and return the page associated
--
2.17.1
\
 
 \ /
  Last update: 2020-05-26 08:43    [W:0.022 / U:0.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site