lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next 2/4] net: phy: mscc-miim: remove redundant timeout check
    Date
    readl_poll_timeout already returns -ETIMEDOUT if the condition isn't
    satisfied, there's no need to check again the condition after calling
    it. Remove the redundant timeout check.

    Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
    ---
    drivers/net/phy/mdio-mscc-miim.c | 8 ++------
    1 file changed, 2 insertions(+), 6 deletions(-)

    diff --git a/drivers/net/phy/mdio-mscc-miim.c b/drivers/net/phy/mdio-mscc-miim.c
    index 0b7544f593fb..42119f661452 100644
    --- a/drivers/net/phy/mdio-mscc-miim.c
    +++ b/drivers/net/phy/mdio-mscc-miim.c
    @@ -43,12 +43,8 @@ static int mscc_miim_wait_ready(struct mii_bus *bus)
    struct mscc_miim_dev *miim = bus->priv;
    u32 val;

    - readl_poll_timeout(miim->regs + MSCC_MIIM_REG_STATUS, val,
    - !(val & MSCC_MIIM_STATUS_STAT_BUSY), 50, 10000);
    - if (val & MSCC_MIIM_STATUS_STAT_BUSY)
    - return -ETIMEDOUT;
    -
    - return 0;
    + return readl_poll_timeout(miim->regs + MSCC_MIIM_REG_STATUS, val,
    + !(val & MSCC_MIIM_STATUS_STAT_BUSY), 50, 10000);
    }

    static int mscc_miim_read(struct mii_bus *bus, int mii_id, int regnum)
    --
    2.26.2
    \
     
     \ /
      Last update: 2020-05-26 18:23    [W:4.193 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site