Messages in this thread | | | Subject | Re: [PATCH v5] arch/x86: Update config and kernel doc for MPK feature on AMD | From | Dave Hansen <> | Date | Tue, 26 May 2020 08:33:36 -0700 |
| |
On 5/23/20 5:21 AM, Borislav Petkov wrote: >> +config X86_MEMORY_PROTECTION_KEYS >> + # Set the "INTEL_"-free option whenever the "INTEL_" one is set. >> + # The "INTEL_" one should be removed and replaced by this option >> + # after 5.10. This avoids exposing most 'oldconfig' users to this >> + # churn. >> + def_bool X86_INTEL_MEMORY_PROTECTION_KEYS > I only picked up the discussion from the sidelines but why do we need > this at all? If we don't want to have churn, then we can leave it be > called X86_INTEL_MEMORY_PROTECTION_KEYS, not change the manpage and > have this depend on CPU_SUP_AMD too so that people can select it on AMD > machines, and get on with our lives. > > So what's up?
Thanks for pointing that out. I think this ended up mixing together the two alternative, which doesn't make much sense.
Babu, let's just leave the config option _naming_ entirely in place. The only change should be to the dependencies and the description text.
| |