lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
On Tue, May 26, 2020 at 08:24:50PM +0530, GAURAV PATHAK wrote:
> On Tue, May 26, 2020 at 05:13:46PM +0300, Dan Carpenter wrote:
> > Your subject doesn't use the correct patch prefix please use.
> >
> > [PATCH] Staging: comedi: dt2814: remove unused assignments
> >
> > Please resend a v2.
> >
> > Correct the references to Sparse as well like Luc said.
> >
> > regards,
> > dan carpenter
> >
>
> Hello Dan,
> Thank you for reviewing and suggesting changes. I have modified the
> patch and attached it with the e-mail to keep this thread conversation.
> I hope I have made the changes correctly.
>

No, this isn't how to send a v2 patch.

https://www.google.com/search?client=firefox-b-d&q=how+to+send+a+v2+patch

Put [PATCH v2] in the subject. Don't send patches as attachments.
Put a comment after the --- cut off line:

Signed-off...
---
v2: Update subject and commit message.

If you want to reply to the thread, that's good. Use --in-reply-to=<Message-id>
But don't worry about it too much. Greg applies or deletes patches as
soon as he sees them so either way he's not going to have the original
thread in his inbox.

regards,
dan carpenter


\
 
 \ /
  Last update: 2020-05-26 17:10    [W:0.076 / U:4.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site