lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] PCI: qcom: Improve exception handling in qcom_pcie_probe()
From
Date
Please avoid a typo in the patch subject (by a possible alternative?).


> In function qcom_pcie_probe(), there are several error-handling problem.

Wording adjustments:
This function contained improvable implementation details according to
exception handling.


> because refcount will be increased even pm_runtime_get_sync() returns
> an error.

because the reference count will be increased despite of the failure.
Thus add the missed function call.


> 2. pm_runtime_disable() are called twice, …

Thus remove redundant function calls.

Regards,
Markus

\
 
 \ /
  Last update: 2020-05-26 16:31    [W:0.053 / U:1.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site