lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: [PATCH] scsi: ufs: Fix runtime PM imbalance on error
> Hi,
>
> On 22/05/20 10:23 am, Dinghao Liu wrote:
> > When devm_clk_get() returns an error code, a pairing
> > runtime PM usage counter decrement is needed to keep
> > the counter balanced.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> > ---
>
> Thanks for the patch! But this fix is incomplete, I have posted
> a more comprehensive fix at [1].. Please take a look!


You are right, we should call pm_runtime_disable() on error, too.
Thank your for your reminder!

Regards,
Dinghao
\
 
 \ /
  Last update: 2020-05-26 12:13    [W:0.417 / U:3.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site