lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 08/10] media: i2c: imx290: Add support to enumerate all frame sizes
Hi Andrey,

On Sun, May 24, 2020 at 10:25:03PM +0300, Andrey Konovalov wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Add support to enumerate all frame sizes supported by IMX290. This is
> required for using with userspace tools such as libcamera.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
> ---
> drivers/media/i2c/imx290.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 6e70ff22bc5f..88850f3b1427 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -471,6 +471,25 @@ static int imx290_enum_mbus_code(struct v4l2_subdev *sd,
> return 0;
> }
>
> +static int imx290_enum_frame_size(struct v4l2_subdev *subdev,
> + struct v4l2_subdev_pad_config *cfg,
> + struct v4l2_subdev_frame_size_enum *fse)
> +{
> + if ((fse->code != imx290_formats[0].code) &&
> + (fse->code != imx290_formats[1].code))
> + return -EINVAL;

Please skip the modes that do not have the code specified by the user. They
should not be enumerated here.

> +
> + if (fse->index >= ARRAY_SIZE(imx290_modes))
> + return -EINVAL;
> +
> + fse->min_width = imx290_modes[fse->index].width;
> + fse->max_width = imx290_modes[fse->index].width;
> + fse->min_height = imx290_modes[fse->index].height;
> + fse->max_height = imx290_modes[fse->index].height;
> +
> + return 0;
> +}
> +
> static int imx290_get_fmt(struct v4l2_subdev *sd,
> struct v4l2_subdev_pad_config *cfg,
> struct v4l2_subdev_format *fmt)
> @@ -850,6 +869,7 @@ static const struct v4l2_subdev_video_ops imx290_video_ops = {
> static const struct v4l2_subdev_pad_ops imx290_pad_ops = {
> .init_cfg = imx290_entity_init_cfg,
> .enum_mbus_code = imx290_enum_mbus_code,
> + .enum_frame_size = imx290_enum_frame_size,
> .get_fmt = imx290_get_fmt,
> .set_fmt = imx290_set_fmt,
> };

--
Regards,

Sakari Ailus

\
 
 \ /
  Last update: 2020-05-26 11:18    [W:0.142 / U:2.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site