Messages in this thread Patch in this message | | | From | Dilip Kota <> | Subject | [PATCH 1/1] phy: intel: Fix compilation error on FIELD_PREP usage | Date | Tue, 26 May 2020 16:43:20 +0800 |
| |
FIELD_PREP expects mask variable datatype as unsigned long and constant. Make the mask argument in combo_phy_w32_off_mask () as unsigned long const datatype.
Error reported as: In file included from include/linux/build_bug.h:5, from include/linux/bitfield.h:10, from drivers/phy/intel/phy-intel-combo.c:8: drivers/phy/intel/phy-intel-combo.c: In function 'combo_phy_w32_off_mask': include/linux/bitfield.h:52:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]
include/linux/compiler.h:350:38: error: call to '__compiletime_assert_37' declared with attribute error: FIELD_PREP: mask is not constant 94 | __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); | ^~~~~~~~~~~~~~~~ drivers/phy/intel/phy-intel-combo.c:137:13: note: in expansion of macro 'FIELD_PREP' 137 | reg_val |= FIELD_PREP(mask, val); | ^~~~~~~~~~
Fixes: ac0a95a3ea78 ("phy: intel: Add driver support for ComboPhy") Signed-off-by: Dilip Kota <eswara.kota@linux.intel.com> Reported-by: kbuild test robot <lkp@intel.com> --- drivers/phy/intel/phy-intel-combo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/intel/phy-intel-combo.c b/drivers/phy/intel/phy-intel-combo.c index c2a35be4cdfb..05b7d724ceb0 100644 --- a/drivers/phy/intel/phy-intel-combo.c +++ b/drivers/phy/intel/phy-intel-combo.c @@ -128,7 +128,7 @@ static int intel_cbphy_pcie_refclk_cfg(struct intel_cbphy_iphy *iphy, bool set) } static inline void combo_phy_w32_off_mask(void __iomem *base, unsigned int reg, - u32 mask, u32 val) + unsigned long const mask, u32 val) { u32 reg_val; -- 2.11.0
| |