lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 071/111] dmaengine: dmatest: Restore default for channel
    Date
    From: Vladimir Murzin <vladimir.murzin@arm.com>

    commit 6b41030fdc79086db5d673c5ed7169f3ee8c13b9 upstream.

    In case of dmatest is built-in and no channel was configured test
    doesn't run with:

    dmatest: Could not start test, no channels configured

    Even though description to "channel" parameter claims that default is
    any.

    Add default channel back as it used to be rather than reject test with
    no channel configuration.

    Fixes: d53513d5dc285d9a95a534fc41c5c08af6b60eac ("dmaengine: dmatest: Add support for multi channel testing)
    Reported-by: Dijil Mohan <Dijil.Mohan@arm.com>
    Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
    Link: https://lore.kernel.org/r/20200429071522.58148-1-vladimir.murzin@arm.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/dma/dmatest.c | 9 +++++----
    1 file changed, 5 insertions(+), 4 deletions(-)

    --- a/drivers/dma/dmatest.c
    +++ b/drivers/dma/dmatest.c
    @@ -1166,10 +1166,11 @@ static int dmatest_run_set(const char *v
    mutex_unlock(&info->lock);
    return ret;
    } else if (dmatest_run) {
    - if (is_threaded_test_pending(info))
    - start_threaded_tests(info);
    - else
    - pr_info("Could not start test, no channels configured\n");
    + if (!is_threaded_test_pending(info)) {
    + pr_info("No channels configured, continue with any\n");
    + add_threaded_test(info);
    + }
    + start_threaded_tests(info);
    } else {
    stop_threaded_test(info);
    }

    \
     
     \ /
      Last update: 2020-05-26 21:11    [W:4.132 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site