[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 5.4 062/111] scsi: qla2xxx: Do not log message when reading port speed via sysfs
From: Ewan D. Milne <>

commit fb9024b0646939e59d8a0b6799b317070619795a upstream.

Calling ql_log() inside qla2x00_port_speed_show() is causing messages to be
output to the console for no particularly good reason. The sysfs read
routine should just return the information to userspace. The only reason
to log a message is when the port speed actually changes, and this already
occurs elsewhere.

Fixes: 4910b524ac9e ("scsi: qla2xxx: Add support for setting port speed")
Cc: <> # v5.1+
Reviewed-by: Lee Duncan <>
Reviewed-by: Laurence Oberman <>
Reviewed-by: Himanshu Madhani <>
Signed-off-by: Ewan D. Milne <>
Signed-off-by: Martin K. Petersen <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/scsi/qla2xxx/qla_attr.c | 3 ---
1 file changed, 3 deletions(-)

--- a/drivers/scsi/qla2xxx/qla_attr.c
+++ b/drivers/scsi/qla2xxx/qla_attr.c
@@ -1775,9 +1775,6 @@ qla2x00_port_speed_show(struct device *d
return -EINVAL;

- ql_log(ql_log_info, vha, 0x70d6,
- "port speed:%d\n", ha->link_data_rate);
return scnprintf(buf, PAGE_SIZE, "%s\n", spd[ha->link_data_rate]);

 \ /
  Last update: 2020-05-26 21:08    [W:0.323 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site