lkml.org 
[lkml]   [2020]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] seccomp: Introduce addfd ioctl to seccomp user notifier
On Sun, May 24, 2020 at 05:27:58PM -0700, Sargun Dhillon wrote:

> > if (addfd->fd >= 0) {
> > ret = replace_fd(addfd->fd, addfd->file, addfd->flags);
> > } else {
> > ret = get_unused_fd_flags(addfd->flags);
> > if (ret >= 0)
> > fd_install(ret, get_file(addfd->file));
^^^^^^^^

> Wouldn't this result in consumption of reference in one case (fd_install),
> and the fd still having a reference in the replace_fd case?

\
 
 \ /
  Last update: 2020-05-25 02:40    [W:0.029 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site