lkml.org 
[lkml]   [2020]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 08/11] net: phy: Allow mdio buses to auto-probe c45 devices
> +++ b/include/linux/phy.h
> @@ -275,6 +275,11 @@ struct mii_bus {
> int reset_delay_us;
> /* RESET GPIO descriptor pointer */
> struct gpio_desc *reset_gpiod;
> + /* bus capabilities, used for probing */
> + enum {
> + MDIOBUS_C22_ONLY = 0,
> + MDIOBUS_C45_FIRST,
> + } probe_capabilities;
> };


I'm not so keen on _FIRST. It suggest _LAST would also be valid. But
that then suggests this is not a bus property, but a PHY property, and
some PHYs might need _FIRST and other phys need _LAST, and then you
have a bus which has both sorts of PHY on it, and you have a problem.

So i think it would be better to have

enum {
MDIOBUS_UNKNOWN = 0,
MDIOBUS_C22,
MDIOBUS_C45,
MDIOBUS_C45_C22,
} bus_capabilities;

Describe just what the bus master can support.

Andrew

\
 
 \ /
  Last update: 2020-05-24 16:45    [W:0.217 / U:3.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site