Messages in this thread | | | From | Andy Shevchenko <> | Date | Sat, 23 May 2020 14:52:33 +0300 | Subject | Re: Re: Re: [PATCH] spi: tegra20-slink: Fix runtime PM imbalance on error |
| |
On Sat, May 23, 2020 at 2:32 PM <dinghao.liu@zju.edu.cn> wrote: > > > On Fri, May 22, 2020 at 6:20 PM Andy Shevchenko > > <andy.shevchenko@gmail.com> wrote: > > > On Fri, May 22, 2020 at 10:46 AM <dinghao.liu@zju.edu.cn> wrote:
...
> I also checked many other implementation of probe in drivers. > It seems that using pm_runtime_put() is ok.
In *error path* or normal path?
> If I misunderstood > your opinion, please point it out, thanks.
Bottom line is (for the *error path* case): pm_runtime_put_noidle() has no side effects pm_runtime_put() (potentially) might have side effects.
You should choose one which is clearer about what it does.
-- With Best Regards, Andy Shevchenko
| |