[lkml]   [2020]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net-next] net: phy: at803x: fix PHY ID masks
From: Michael Walle <>
Date: Fri, 22 May 2020 11:53:31 +0200

> Ever since its first commit 0ca7111a38f05 ("phy: add AT803x driver") the
> PHY ID mask was set to 0xffffffef. It is unclear to me why this mask was
> chosen in the first place. Both the AR8031/AR8033 and the AR8035
> datasheets mention it is always the given value:
> - for AR8031/AR8033 its 0x004d/0xd074
> - for AR8035 its 0x004d/0xd072
> Unfortunately, I don't have a datasheet for the AR8030. Therefore, we
> leave its PHY ID mask untouched. For the PHYs mentioned before use the
> handy PHY_ID_MATCH_EXACT() macro.
> I've tried to contact the author of the initial commit, but received no
> answer so far.
> Cc: Matus Ujhelyi <>
> Signed-off-by: Michael Walle <>

Applied, thank you.

 \ /
  Last update: 2020-05-24 01:27    [W:0.039 / U:2.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site