lkml.org 
[lkml]   [2020]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm/vblank: Fix -Wformat compile warnings on some arches
Hi Lyude.

> > > *dev, unsigned int pipe,
> > >
> > > DRM_DEBUG_VBL("updating vblank count on crtc %u:"
> > > " current=%llu, diff=%u, hw=%u hw_last=%u\n",
> > > - pipe, atomic64_read(&vblank->count), diff,
> > > + pipe, (unsigned long long)atomic64_read(&vblank->count),
> > > diff,
> > > cur_vblank, vblank->last);
> >
> > While touching this you could consider introducing drm_dbg_vbl().
> > An maybe as a follow-up patch replace all logging in this file with the drm_*
> > variants.
>
> ok - no promises when I can actually get to this though, I've got a lot on my
> plate ATM

I wnet ahead and applied this patch (after fixing a too long line),
and then I updated the logging functions as suggested above.
I applied the patch to drm-misc-next.

Patches with updated logging coming.

Sam

\
 
 \ /
  Last update: 2020-05-23 08:54    [W:0.059 / U:2.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site