lkml.org 
[lkml]   [2020]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe()
Hi,

On 23/05/2020 17:56:21+0800, Tiezhu Yang wrote:
> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
> to check the return value and return PTR_ERR() if failed.
>
> Fixes: 89576bebbc17 ("rtc: Use devm_platform_ioremap_resource()")

This doesn't fix an issue and it was anyway not introduced by that
commit. Please correct your commit message and subject.

> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> drivers/rtc/rtc-goldfish.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c
> index cb6b0ad..2779715 100644
> --- a/drivers/rtc/rtc-goldfish.c
> +++ b/drivers/rtc/rtc-goldfish.c
> @@ -174,7 +174,7 @@ static int goldfish_rtc_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, rtcdrv);
> rtcdrv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(rtcdrv->base))
> - return -ENODEV;
> + return PTR_ERR(rtcdrv->base);
>
> rtcdrv->irq = platform_get_irq(pdev, 0);
> if (rtcdrv->irq < 0)
> --
> 2.1.0
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2020-05-23 21:50    [W:0.046 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site