lkml.org 
[lkml]   [2020]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RESEND PATCH] thermal: mediatek: add suspend/resume callback
    From
    Date
    On 08/04/2020 11:05, Michael Kao wrote:
    > From: Louis Yu <louis.yu@mediatek.com>
    >
    > Add suspend/resume callback to disable/enable Mediatek thermal sensor
    > respectively. Since thermal power domain is off in suspend, thermal driver
    > needs re-initialization during resume.
    >
    > Signed-off-by: Louis Yu <louis.yu@mediatek.com>
    > Signed-off-by: Michael Kao <michael.kao@mediatek.com>

    [ ... ]

    > +static int __maybe_unused mtk_thermal_suspend(struct device *dev)
    > +{
    > + struct platform_device *pdev = to_platform_device(dev);
    > + struct mtk_thermal *mt = platform_get_drvdata(pdev);
    > + int i, ret;
    > +

    Why is there a multi-controller loop in the probe and resume functions
    and not here?

    > + for (i = 0; i < mt->conf->num_banks; i++) {
    > + ret = mtk_thermal_disable_sensing(mt, i);
    > + if (ret)
    > + goto out;
    > + }
    > +
    > + /* disable buffer */
    > + writel(readl(mt->apmixed_base + APMIXED_SYS_TS_CON1) |
    > + APMIXED_SYS_TS_CON1_BUFFER_OFF,
    > + mt->apmixed_base + APMIXED_SYS_TS_CON1);
    > +
    > + clk_disable_unprepare(mt->clk_peri_therm);
    > + clk_disable_unprepare(mt->clk_auxadc);
    > +
    > + return 0;
    > +
    > +out:
    > + dev_err(&pdev->dev, "Failed to wait until bus idle\n");
    > +
    > + return ret;
    > +}
    > +
    > +static int __maybe_unused mtk_thermal_resume(struct device *dev)
    > +{
    > + struct platform_device *pdev = to_platform_device(dev);
    > + struct mtk_thermal *mt = platform_get_drvdata(pdev);
    > + int i, ret, ctrl_id;
    > +
    > + ret = device_reset(&pdev->dev);
    > + if (ret)
    > + return ret;
    > +
    > + ret = clk_prepare_enable(mt->clk_auxadc);
    > + if (ret) {
    > + dev_err(&pdev->dev, "Can't enable auxadc clk: %d\n", ret);
    > + goto err_disable_clk_auxadc;
    > + }
    > +
    > + ret = clk_prepare_enable(mt->clk_peri_therm);
    > + if (ret) {
    > + dev_err(&pdev->dev, "Can't enable peri clk: %d\n", ret);
    > + goto err_disable_clk_peri_therm;
    > + }
    > +
    > + for (ctrl_id = 0; ctrl_id < mt->conf->num_controller ; ctrl_id++)
    > + for (i = 0; i < mt->conf->num_banks; i++)
    > + mtk_thermal_init_bank(mt, i, mt->apmixed_phys_base,
    > + mt->auxadc_phys_base, ctrl_id);
    > +
    > + return 0;
    > +
    > +err_disable_clk_peri_therm:
    > + clk_disable_unprepare(mt->clk_peri_therm);
    > +err_disable_clk_auxadc:
    > + clk_disable_unprepare(mt->clk_auxadc);
    > +
    > + return ret;
    > +}
    > +
    > +static SIMPLE_DEV_PM_OPS(mtk_thermal_pm_ops,
    > + mtk_thermal_suspend, mtk_thermal_resume);
    > +
    > static struct platform_driver mtk_thermal_driver = {
    > .probe = mtk_thermal_probe,
    > .remove = mtk_thermal_remove,
    > .driver = {
    > .name = "mtk-thermal",
    > + .pm = &mtk_thermal_pm_ops,
    > .of_match_table = mtk_thermal_of_match,
    > },
    > };
    >


    --
    <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

    Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
    <http://twitter.com/#!/linaroorg> Twitter |
    <http://www.linaro.org/linaro-blog/> Blog

    \
     
     \ /
      Last update: 2020-05-22 21:09    [W:3.936 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site