lkml.org 
[lkml]   [2020]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu()
From
Date
On 5/22/20 9:12 AM, Mark Brown wrote:
> On Fri, May 22, 2020 at 08:55:50AM -0600, shuah wrote:
>> On 5/19/20 11:44 AM, Mark Brown wrote:
>
>>>> WARNING: Missing a blank line after declarations
>>>> WARNING: Missing a blank line after declarations
>>>> #135: FILE: tools/testing/selftests/vDSO/vdso_test_getcpu.c:27:
>>>> + unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR);
>
>> A blank line after declarations here just like what checkpatch
>> suggests. It makes it readable.
>
> That doesn't match the idiom used by any of the surrounding code :(
>

I can't parse the idiom statement? Can you clarify it please.

thanks,
-- Shuah

\
 
 \ /
  Last update: 2020-05-22 17:15    [W:0.039 / U:24.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site