lkml.org 
[lkml]   [2020]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] rxrpc: Fix a memory leak in rxkad_verify_response()
From
Date
> In function rxkad_verify_response(), pointer "ticket" is not released,
> when function rxkad_decrypt_ticket() returns an error, causing a
> memory leak bug.

I suggest to improve also this change description.
How do you think about a wording variant like the following?

A ticket was not released after a call of the function “platform_get_irq” failed.
Thus replace the jump target “temporary_error_free_resp”
by “temporary_error_free_ticket”.


Regards,
Markus

\
 
 \ /
  Last update: 2020-05-22 08:31    [W:0.040 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site