Messages in this thread | | | Date | Fri, 22 May 2020 15:26:31 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v13 11/11] pwm: core: Convert period and duty cycle to u64 |
| |
On Tue, Apr 21, 2020 at 07:57:23PM -0700, Guru Das Srinagesh wrote: > Because period and duty cycle are defined as ints with units of > nanoseconds, the maximum time duration that can be set is limited to > ~2.147 seconds. Change their definitions to u64 in the structs of the > PWM framework so that higher durations may be set. > > Also use the right format specifiers in debug prints in both core.c as > well as pwm-stm32-lp.c. > > Cc: Fabrice Gasnier <fabrice.gasnier@st.com> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: Joe Perches <joe@perches.com> > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
I like this change in general. I didn't check all the prepatory patches in detail but the few I glanced over looked ok.
I think we have to prepare for having to fix a few fallouts but consider it ok to expose this in next (but wouldn't send it for 5.8-rc1 yet).
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
| |