lkml.org 
[lkml]   [2020]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: [PATCH] [v2] usb: musb: Fix runtime PM imbalance on error
Sorry, it's my carelessness. In v1 I added pm_runtime_put_autosuspend()
after copy_from_user() to fix this problem. Since copy_from_user() is
moved to the beginning now, we need not to add PM decrement.

Regards,
Dinghao

> On Fri, May 22, 2020 at 10:59:02AM +0800, Dinghao Liu wrote:
> > When copy_from_user() returns an error code, there
> > is a runtime PM usage counter imbalance.
> >
> > Fix this by moving copy_from_user() to the beginning
> > of this function.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> > ---
> > drivers/usb/musb/musb_debugfs.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
>
> What changed from v1? Always show that below the --- line as the
> documentation says to.
>
> thanks,
>
> greg k-h
\
 
 \ /
  Last update: 2020-05-22 07:23    [W:0.051 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site