lkml.org 
[lkml]   [2020]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mmc: Fix use after free in mmc_rpmb_chrdev_release()
From
Date
> This is caused by dereferencing 'rpmb' after put_device().

I suggest to improve also this change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=051143e1602d90ea71887d92363edd539d411de5#n151

How do you think about a wording variant like the following?

The data structure member “rpmb->md” was passed to a call of
the function “mmc_blk_put” after a call of the function “put_device”.
Reorder these function calls to keep the data accesses consistent.


Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus

\
 
 \ /
  Last update: 2020-05-22 11:10    [W:0.030 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site