lkml.org 
[lkml]   [2020]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/3] extcon: max14577: Add proper dt-compatible strings
From
Date
Hi Chanwoo,

On 22.05.2020 09:08, Chanwoo Choi wrote:
> On 5/22/20 3:48 PM, Marek Szyprowski wrote:
>> Add device tree compatible strings and create proper modalias structures
>> to let this driver load automatically if compiled as module, because
>> max14577 MFD driver creates MFD cells with such compatible strings.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> v2:
>> - added .of_match_table pointer
>> ---
>> drivers/extcon/extcon-max14577.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
>> index 32f663436e6e..03af678ddeba 100644
>> --- a/drivers/extcon/extcon-max14577.c
>> +++ b/drivers/extcon/extcon-max14577.c
>> @@ -782,9 +782,19 @@ static const struct platform_device_id max14577_muic_id[] = {
>> };
>> MODULE_DEVICE_TABLE(platform, max14577_muic_id);
>>
>> +static const struct of_device_id of_max14577_muic_dt_match[] = {
>> + { .compatible = "maxim,max77836-muic",
>> + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
>> + { .compatible = "maxim,max14577-muic",
>> + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
>> + { },
> How about changing the order between max77836 and max14577 as already added structure
> like platform_device_id if there are no specific reason as following:?
>
>
> static const struct of_device_id of_max14577_muic_dt_match[] = {
> { .compatible = "maxim,max14577-muic",
> .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
> { .compatible = "maxim,max77836-muic",
> .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
> { },

Sure. I will swap them and send updated patch. This order comes from
drivers/power/supply/max14577_charger.c, which also lacks
.of_match_table, so I will also fix it.

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland

\
 
 \ /
  Last update: 2020-05-22 10:31    [W:0.063 / U:5.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site