lkml.org 
[lkml]   [2020]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: ethernet: stmmac: Enable interface clocks on probe for IPQ806x
From
From: Jonathan McDowell <noodles@earth.li>
Date: Thu, 21 May 2020 12:49:34 +0100

> The ipq806x_gmac_probe() function enables the PTP clock but not the
> appropriate interface clocks. This means that if the bootloader hasn't
> done so attempting to bring up the interface will fail with an error
> like:
>
> [ 59.028131] ipq806x-gmac-dwmac 37600000.ethernet: Failed to reset the dma
> [ 59.028196] ipq806x-gmac-dwmac 37600000.ethernet eth1: stmmac_hw_setup: DMA engine initialization failed
> [ 59.034056] ipq806x-gmac-dwmac 37600000.ethernet eth1: stmmac_open: Hw setup failed
>
> This patch, a slightly cleaned up version of one posted by Sergey
> Sergeev in:
>
> https://forum.openwrt.org/t/support-for-mikrotik-rb3011uias-rm/4064/257
>
> correctly enables the clock; we have already configured the source just
> before this.
>
> Tested on a MikroTik RB3011.
>
> Signed-off-by: Jonathan McDowell <noodles@earth.li>

Applied, thanks.

\
 
 \ /
  Last update: 2020-05-23 01:08    [W:0.027 / U:29.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site