Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 21 May 2020 11:30:51 +0200 | Subject | Re: [PATCH v4 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support |
| |
On Thu, May 21, 2020 at 11:17 AM Will Deacon <will@kernel.org> wrote: > On Thu, May 21, 2020 at 11:06:23AM +0200, Arnd Bergmann wrote: > > On Thu, May 21, 2020 at 10:11 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > Note that the warning should come up for either W=1 or C=1, and I also > > think that > > new code should generally be written sparse-clean and have no warnings with > > 'make C=1' as a rule. > > Fair enough. Is anybody working on a tree-wide sweep for this, like we've > done for other things such as zero-length arrays? If so, I can start > enforcing this in the arch code as well (I haven't been so far, even though > I do run sparse on every commit).
I've done some work on that a few years ago, and there are always some cleanup patches for C=1 and W=1 warnings, most recently with an increase from Huawei's automated build testing + manual patching.
I have not looked in a while, but it always seemed to be somewhere between "too much to do by myself" and "small enough that it should really be done" as build warnings go.
Arnd
| |