Messages in this thread | | | Date | Fri, 22 May 2020 11:09:19 +0800 | From | Leo Yan <> | Subject | Re: [PATCH v7 0/3] perf arm-spe: Add support for synthetic events |
| |
Hi,
On Mon, May 04, 2020 at 07:56:22PM +0800, Leo Yan wrote: > This patch set is to support synthetic events with enabling Arm SPE > decoder. Since before Xiaojun Tan (Hisilicon) and James Clark (Arm) > have contributed much for this task, so this patch set is based on their > privous work and polish for the version 7. > > The main work in this version is to polished the core patch "perf > arm-spe: Support synthetic events", e.g. rewrite the code to calculate > ip, packet generation for multiple types (L1 data cache, Last level > cache, TLB, remote access, etc). It also heavily refactors code for > data structure and program flow, which removed unused fields in > structure and polished the program flow to achieve neat code as > possible. > > This patch set has been checked with checkpatch.pl, though it leaves > several warnings, but these warnings are delibarately kept after > reviewing. Some warnings ask to add maintainer (so far it's not > necessary), and some warnings complaint for patch 02 "perf auxtrace: > Add four itrace options" for the text format, since need to keep the > consistency with the same code format in the source code, this is why > this patch doesn't get rid of checkpatch warnings.
Gentle ping ...
It would be appreciate if can get some review for this patch set.
Thanks, Leo
> Tan Xiaojun (3): > perf tools: Move arm-spe-pkt-decoder.h/c to the new dir > perf auxtrace: Add four itrace options > perf arm-spe: Support synthetic events > > tools/perf/Documentation/itrace.txt | 6 +- > tools/perf/util/Build | 2 +- > tools/perf/util/arm-spe-decoder/Build | 1 + > .../util/arm-spe-decoder/arm-spe-decoder.c | 219 +++++ > .../util/arm-spe-decoder/arm-spe-decoder.h | 82 ++ > .../arm-spe-pkt-decoder.c | 0 > .../arm-spe-pkt-decoder.h | 16 + > tools/perf/util/arm-spe.c | 823 +++++++++++++++++- > tools/perf/util/auxtrace.c | 17 + > tools/perf/util/auxtrace.h | 15 +- > 10 files changed, 1135 insertions(+), 46 deletions(-) > create mode 100644 tools/perf/util/arm-spe-decoder/Build > create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.c > create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.h > rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.c (100%) > rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.h (64%) > > -- > 2.17.1 >
| |