lkml.org 
[lkml]   [2020]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 12/12] mmap locking API: convert mmap_sem comments
On Thu, May 21, 2020 at 12:42 AM Vlastimil Babka <vbabka@suse.cz> wrote:
> On 5/20/20 7:29 AM, Michel Lespinasse wrote:
> > Convert comments that reference mmap_sem to reference mmap_lock instead.
> >
> > Signed-off-by: Michel Lespinasse <walken@google.com>
>
> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
>
> But:
>
> > diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> > index a1247d3553da..1bf46e2e0cec 100644
> > --- a/mm/mempolicy.c
> > +++ b/mm/mempolicy.c
> > @@ -224,7 +224,7 @@ static int mpol_new_bind(struct mempolicy *pol, const nodemask_t *nodes)
> > * handle an empty nodemask with MPOL_PREFERRED here.
> > *
> > * Must be called holding task's alloc_lock to protect task's mems_allowed
> > - * and mempolicy. May also be called holding the mmap_semaphore for write.
> > + * and mempolicy. May also be called holding the mmap_lockaphore for write.
> > */
> > static int mpol_set_nodemask(struct mempolicy *pol,
> > const nodemask_t *nodes, struct nodemask_scratch *nsc)
>
> :)

Haha, good catch !

--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.

\
 
 \ /
  Last update: 2020-05-21 09:52    [W:0.112 / U:3.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site