lkml.org 
[lkml]   [2020]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch V6 01/37] tracing/hwlat: Use ktime_get_mono_fast_ns()
Date
Steven Rostedt <rostedt@goodmis.org> writes:

> On Tue, 19 May 2020 23:45:10 +0200
> Thomas Gleixner <tglx@linutronix.de> wrote:
>
>> >> @@ -165,20 +155,22 @@ void trace_hwlat_callback(bool enter)
>> >> * Used to repeatedly capture the CPU TSC (or similar), looking for potential
>> >> * hardware-induced latency. Called with interrupts disabled and with
>> >> * hwlat_data.lock held.
>> >> + *
>> >> + * Use ktime_get_mono_fast() here as well because it does not wait on the
>> >> + * timekeeping seqcount like ktime_get_mono().
>> >
>> > When doing a "git grep ktime_get_mono" I only find
>> > ktime_get_mono_fast_ns() (and this comment), so I don't know what to compare
>> > that to. Did you mean another function?
>>
>> Yeah. I fatfingered the comment. The code uses ktime_get_mono_fast_ns().
>
> Well, I assumed that's what you meant with "ktime_get_mono_fast()" but I
> don't know what function you are comparing it to that waits on the seqcount
> like "ktime_get_mono()" as there is no such function.

Gah. ktime_get_mono_fast_ns() and ktime_get() of course.

\
 
 \ /
  Last update: 2020-05-20 21:52    [W:0.150 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site