lkml.org 
[lkml]   [2020]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Input: omap-keypad - fix runtime pm imbalance on error
Hi Dinghao,

On Wed, May 20, 2020 at 6:35 AM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
>
> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a pairing decrement is needed
> on the error handling path to keep the counter balanced.

This is a very surprising behavior and I wonder if this should be
fixed in the PM core (or the required cleanup steps need to be called
out in the function description). I also see that a few drivers that
handle this situation correctly (?) call pm_runtime_put_noidle()
instead of pm_runtime_put_sync() in the error path.

Rafael, do you have any guidance here?

Thanks.

--
Dmitry

\
 
 \ /
  Last update: 2020-05-20 19:03    [W:0.279 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site