Messages in this thread | | | Date | Sat, 2 May 2020 09:40:24 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] streamline_config.pl: add LOCALMODCONFIG_PRESERVE to preserve some kconfigs |
| |
On Sat, 2 May 2020 21:30:54 +0800 Changbin Du <changbin.du@gmail.com> wrote:
> > > Sometimes it is useful to preserve batches of configs when making > > > localmodconfig. For example, I usually don't want any usb and fs > > > modules to be disabled. Now we can do it by: > > > > > > $ make LOCALMODCONFIG_PRESERVE="drivers/usb;fs" localmodconfig > > > > That's too much typing ;-) What about just "KEEP='drivers/usb;fs'"? > > > I think we'd better use a long name since it will be passed to the entire kbuild. > And we alreay have one named LOCALMODCONFIG_DEBUG. The prefix LOCALMODCONFIG_ > can help to avoid namespace pollution.
I politely disagree. Build options is not common. The LOCALMODCONFIG_DEBUG is an environment variable, which I couldn't just use DEBUG.
If you absolutely require a prefix, shorten it to LMC_ or something. I already hate typing 'localmodconfig' once ;-)
-- Steve
| |