lkml.org 
[lkml]   [2020]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 08/10] mmap locking API: add MMAP_LOCK_INITIALIZER
On Mon, May 18, 2020 at 12:45:06PM +0200, Vlastimil Babka wrote:
> On 4/22/20 2:14 AM, Michel Lespinasse wrote:
> > Define a new initializer for the mmap locking api.
> > Initially this just evaluates to __RWSEM_INITIALIZER as the API
> > is defined as wrappers around rwsem.
> >
> > Signed-off-by: Michel Lespinasse <walken@google.com>
>
>
> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
>
>
> Nit below.
>
> > +#define MMAP_LOCK_INITIALIZER(name) \
> > + .mmap_sem = __RWSEM_INITIALIZER(name.mmap_sem),
>
> "(name).mmap_sem" is safer in a macro?

Thanks, applied in next version.

--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.

\
 
 \ /
  Last update: 2020-05-19 14:58    [W:0.074 / U:1.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site