Messages in this thread | | | Date | Tue, 19 May 2020 11:48:35 +0200 | From | Jonathan Albrieux <> | Subject | Re: [PATCH v2 0/3] iio: magnetometer: ak8975: Add gpio reset support |
| |
On Tue, May 19, 2020 at 12:22:12PM +0300, Andy Shevchenko wrote: > On Tue, May 19, 2020 at 08:57:40AM +0200, Jonathan Albrieux wrote: > > Convert documentation from txt format to yaml. Add documentation about > > reset-gpio. > > Trailing white space (though it doesn't matter here, in cover letter). >
Ok will fix it!
> > Deassert reset on ak8975_power_on, assert reset on ak8975_power_off. > > > > Without reset's deassertion during ak8975_power_on, driver's probe fails > > on ak8975_who_i_am while checking for device identity for AK09911 chip > > > > AK09911 has an active low reset gpio to handle register's reset. > > AK09911 datasheed says that, if not used, reset pin should be connected > > to VID. This patch emulates this situation > > I dunno if it's your first submission to Linux kernel project or other OSS, > but here you missed a changelog. Rule of thumb is to provide a summary of > the changes done in the history of the evolution of a patch series. >
Oh thank you and sorry for not having included it.
Does the changelog needs to be added to all patch files or just on the ones subject of the changes?
> -- > With Best Regards, > Andy Shevchenko > >
Best regards, Jonathan Albrieux
| |