lkml.org 
[lkml]   [2020]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 03/86] dp83640: reverse arguments to list_add_tail
    Date
    From: Julia Lawall <Julia.Lawall@inria.fr>

    [ Upstream commit 865308373ed49c9fb05720d14cbf1315349b32a9 ]

    In this code, it appears that phyter_clocks is a list head, based on
    the previous list_for_each, and that clock->list is intended to be a
    list element, given that it has just been initialized in
    dp83640_clock_init. Accordingly, switch the arguments to
    list_add_tail, which takes the list head as the second argument.

    Fixes: cb646e2b02b27 ("ptp: Added a clock driver for the National Semiconductor PHYTER.")
    Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/phy/dp83640.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/phy/dp83640.c
    +++ b/drivers/net/phy/dp83640.c
    @@ -1107,7 +1107,7 @@ static struct dp83640_clock *dp83640_clo
    goto out;
    }
    dp83640_clock_init(clock, bus);
    - list_add_tail(&phyter_clocks, &clock->list);
    + list_add_tail(&clock->list, &phyter_clocks);
    out:
    mutex_unlock(&phyter_clocks_lock);


    \
     
     \ /
      Last update: 2020-05-18 19:39    [W:3.676 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site