Messages in this thread | | | Date | Mon, 18 May 2020 15:42:29 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH] iommu/mediatek-v1: Add def_domain_type |
| |
On Fri, May 15, 2020 at 04:08:43PM +0800, Yong Wu wrote: > The MediaTek V1 IOMMU is arm32 whose default domain type is > IOMMU_DOMAIN_UNMANAGED. Add this to satisfy the bus_iommu_probe to > enter "probe_finalize". > > The iommu framework will create a iommu domain for each a device. > But all the devices share a iommu domain here, thus we skip all the > other domains in the "attach_device" except the domain we create > internally with arm_iommu_create_mapping. > > Also a minor change: in the attach_device, "data" always is not null. > Remove "if (!data) return". > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > --- > a. rebase on linux-next. > b. After this patch and fixed the mutex issue(locally I only move > mutex_unlock(&group->mutex) before __iommu_group_dma_attach(group)), > the mtk_iommu_v1.c could work normally. > --- > drivers/iommu/mtk_iommu_v1.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-)
Applied, thanks.
| |