Messages in this thread | | | Subject | Re: [RFC] mm/gup.c: Use gup_flags as parameter instead of passing write flag | From | John Hubbard <> | Date | Mon, 18 May 2020 14:22:38 -0700 |
| |
On 2020-05-18 14:06, Souptick Joarder wrote: ... >> So in other words, if you do go out and change all the call sites (there only >> seem to be about 7, outside of gup.c, actually), that's going to conflict >> a little bit with what I'm doing here. >> >> So, how would you like proceed? If you want to do the full conversion >> (which really should include the call sites), it would be easier for me >> if you based it on my upcoming small patchset, which I expect to post >> shortly (later today). > > Sure, I will wait for your patchset :) > > As there are only 7 callers of the __get_user_pages_fast(), I prefer to do > full conversion in a single commit. But if it is not preferred way, I would go > as per feedback. >
Thanks, I appreciate it! And yes, you'll want to do the "write" to "gup_flags" conversion in a single patch, definitely.
thanks, -- John Hubbard NVIDIA
| |