Messages in this thread | | | Date | Mon, 18 May 2020 11:29:26 -0700 | From | Matt Helsley <> | Subject | Re: [RFC][PATCH 5/5] objtool: Report missing support for subcommands |
| |
On Fri, May 15, 2020 at 04:04:48PM -0500, Josh Poimboeuf wrote: > On Mon, May 11, 2020 at 10:35:13AM -0700, Matt Helsley wrote: > > The check and orc-related subcommands for objtool are x86-specific. > > To make this clear to anyone using the tool return a non-zero exit > > code and indicate in the help and usage output which commands are > > (and are not) available. > > > > Signed-off-by: Matt Helsley <mhelsley@vmware.com> > > I think I'd rather the simplest approach of just having the weak > functions print an error and return an error code. At least for now I > don't think we need to go through the trouble of advertising whether > certain commands are available. Technically they are available, they > just always fail :-)
OK, that'll drop this patch from the series.
> > And, people don't tend to use objtool directly anyway. > > BTW, several of the patches didn't apply cleanly to tip/master, so > you'll probably need to rebase for v2. There've been a lot of objtool > changes lately. Peter's been busy...
Will do.
Cheers, -Matt Helsley
| |