lkml.org 
[lkml]   [2020]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 087/147] RDMA/core: Fix double put of resource
    Date
    [ Upstream commit 50bbe3d34fea74b7c0fabe553c40c2f4a48bb9c3 ]

    Do not decrease the reference count of resource tracker object twice in
    the error flow of res_get_common_doit.

    Fixes: c5dfe0ea6ffa ("RDMA/nldev: Add resource tracker doit callback")
    Link: https://lore.kernel.org/r/20200507062942.98305-1-leon@kernel.org
    Signed-off-by: Maor Gottlieb <maorg@mellanox.com>
    Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/core/nldev.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
    index ef4b0c7061e4c..244ebf285fc3f 100644
    --- a/drivers/infiniband/core/nldev.c
    +++ b/drivers/infiniband/core/nldev.c
    @@ -1248,10 +1248,10 @@ static int res_get_common_doit(struct sk_buff *skb, struct nlmsghdr *nlh,

    has_cap_net_admin = netlink_capable(skb, CAP_NET_ADMIN);
    ret = fe->fill_res_func(msg, has_cap_net_admin, res, port);
    - rdma_restrack_put(res);
    if (ret)
    goto err_free;

    + rdma_restrack_put(res);
    nlmsg_end(msg, nlh);
    ib_device_put(device);
    return rdma_nl_unicast(sock_net(skb->sk), msg, NETLINK_CB(skb).portid);
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-05-18 20:17    [W:3.945 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site