lkml.org 
[lkml]   [2020]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] efi: Pull up arch-specific prototype efi_systab_show_arch()
    On Sat, May 16, 2020 at 03:32:25PM +0200, Ard Biesheuvel wrote:
    > On Sat, 16 May 2020 at 15:26, Benjamin Thiel <b.thiel@posteo.de> wrote:
    > >
    > > ... in order to fix a -Wmissing-prototypes warning:
    > >
    > > arch/x86/platform/efi/efi.c:957:7: warning: no previous prototype for
    > > ‘efi_systab_show_arch’ [-Wmissing-prototypes]
    > > char *efi_systab_show_arch(char *str)
    > >
    > > Signed-off-by: Benjamin Thiel <b.thiel@posteo.de>
    >
    > Thanks, I'll queue this as a fix.
    >
    > Nit: please don't treat the subject line as the first N words of the
    > commit log, but start with a full sentence. Not all mail readers show
    > the subject line and the body together. I've fixed it up for now.

    That was my suggestion as I do that a lot. :)

    --
    Regards/Gruss,
    Boris.

    https://people.kernel.org/tglx/notes-about-netiquette

    \
     
     \ /
      Last update: 2020-05-16 15:39    [W:2.759 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site