lkml.org 
[lkml]   [2020]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()
    On Fri, May 15, 2020 at 09:28:43PM +0000, Luis Chamberlain wrote:
    > This makes use of the new module_firmware_crashed() to help
    > annotate when firmware for device drivers crash. When firmware
    > crashes devices can sometimes become unresponsive, and recovery
    > sometimes requires a driver unload / reload and in the worst cases
    > a reboot.
    >
    > Using a taint flag allows us to annotate when this happens clearly.
    >
    > Cc: linux-wireless@vger.kernel.org
    > Cc: ath10k@lists.infradead.org
    > Cc: Kalle Valo <kvalo@codeaurora.org>
    > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
    > ---
    > drivers/net/wireless/ath/ath10k/pci.c | 2 ++
    > drivers/net/wireless/ath/ath10k/sdio.c | 2 ++
    > drivers/net/wireless/ath/ath10k/snoc.c | 1 +
    > 3 files changed, 5 insertions(+)
    >
    > diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
    > index 1d941d53fdc9..6bd0f3b518b9 100644
    > --- a/drivers/net/wireless/ath/ath10k/pci.c
    > +++ b/drivers/net/wireless/ath/ath10k/pci.c
    > @@ -1767,6 +1767,7 @@ static void ath10k_pci_fw_dump_work(struct work_struct *work)
    > scnprintf(guid, sizeof(guid), "n/a");
    >
    > ath10k_err(ar, "firmware crashed! (guid %s)\n", guid);
    > + module_firmware_crashed();
    > ath10k_print_driver_info(ar);
    > ath10k_pci_dump_registers(ar, crash_data);
    > ath10k_ce_dump_registers(ar, crash_data);
    > @@ -2837,6 +2838,7 @@ static int ath10k_pci_hif_power_up(struct ath10k *ar,
    > if (ret) {
    > if (ath10k_pci_has_fw_crashed(ar)) {
    > ath10k_warn(ar, "firmware crashed during chip reset\n");
    > + module_firmware_crashed();
    > ath10k_pci_fw_crashed_clear(ar);
    > ath10k_pci_fw_crashed_dump(ar);
    > }
    > diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c
    > index e2aff2254a40..d34ad289380f 100644
    > --- a/drivers/net/wireless/ath/ath10k/sdio.c
    > +++ b/drivers/net/wireless/ath/ath10k/sdio.c
    > @@ -794,6 +794,7 @@ static int ath10k_sdio_mbox_proc_dbg_intr(struct ath10k *ar)
    >
    > /* TODO: Add firmware crash handling */
    > ath10k_warn(ar, "firmware crashed\n");
    > + module_firmware_crashed();
    >
    > /* read counter to clear the interrupt, the debug error interrupt is
    > * counter 0.
    > @@ -915,6 +916,7 @@ static int ath10k_sdio_mbox_proc_cpu_intr(struct ath10k *ar)
    > if (cpu_int_status & MBOX_CPU_STATUS_ENABLE_ASSERT_MASK) {
    > ath10k_err(ar, "firmware crashed!\n");
    > queue_work(ar->workqueue, &ar->restart_work);
    > + module_firmware_crashed();
    > }
    > return ret;
    > }
    > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
    > index 354d49b1cd45..7cfc123c345c 100644
    > --- a/drivers/net/wireless/ath/ath10k/snoc.c
    > +++ b/drivers/net/wireless/ath/ath10k/snoc.c
    > @@ -1451,6 +1451,7 @@ void ath10k_snoc_fw_crashed_dump(struct ath10k *ar)
    > scnprintf(guid, sizeof(guid), "n/a");
    >
    > ath10k_err(ar, "firmware crashed! (guid %s)\n", guid);
    > + module_firmware_crashed();
    > ath10k_print_driver_info(ar);
    > ath10k_msa_dump_memory(ar, crash_data);
    > mutex_unlock(&ar->dump_mutex);
    > --
    > 2.26.2
    >
    Acked-by: Rafael Aquini <aquini@redhat.com>

    \
     
     \ /
      Last update: 2020-05-16 06:13    [W:6.715 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site