Messages in this thread | | | Subject | Re: [PATCH AUTOSEL 5.6 30/62] net: Make PTP-specific drivers depend on PTP_1588_CLOCK | From | Grygorii Strashko <> | Date | Fri, 15 May 2020 15:07:43 +0300 |
| |
On 15/05/2020 00:40, Arnd Bergmann wrote: > On Thu, May 14, 2020 at 8:52 PM Sasha Levin <sashal@kernel.org> wrote: >> >> From: Clay McClure <clay@daemons.net> >> >> [ Upstream commit b6d49cab44b567b3e0a5544b3d61e516a7355fad ] >> >> Commit d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") changed >> all PTP-capable Ethernet drivers from `select PTP_1588_CLOCK` to `imply >> PTP_1588_CLOCK`, "in order to break the hard dependency between the PTP >> clock subsystem and ethernet drivers capable of being clock providers." > > I don't think this one should be backported unless 3a9dd3ecb207 ("kconfig: > make 'imply' obey the direct dependency") is already backported to v5.6 > (which I don't think it should either). > Yes. pls, drop it. It's rather optimization, not a fix. And it might introduce build failures.
-- Best regards, grygorii
| |