Messages in this thread | | | From | Bo YU <> | Date | Fri, 15 May 2020 17:23:56 +0800 | Subject | Re: [PATCH -next] fs/btrfs: Fix unlocking in btrfs_ref_tree_mod |
| |
Hi, On Fri, May 15, 2020 at 5:03 PM Johannes Thumshirn <Johannes.Thumshirn@wdc.com> wrote: > > On 15/05/2020 04:17, Bo YU wrote: > > It adds spin_lock() in add_block_entry() but out path does not unlock > > it. > > Which call path doesn't unlock it? There is an out_unlock label with a > spin_unlock() right above your insert. So either coverity messed something > up or the call path that needs the unlock has to jump to out_unlock instead > of out. This is out label without unlocking it. It will be offered spin_lock in add_block_entry() for be. But here I was worried about that unlock it in if() whether it is right or not.
| |