Messages in this thread | | | From | Arnaldo Carvalho de Melo <> | Date | Thu, 14 May 2020 10:49:36 -0300 | Subject | Re: [PATCH v2] perf parse-events: Make add PMU verbose output clearer |
| |
Em Thu, May 14, 2020 at 10:21:15AM +0200, Jiri Olsa escreveu: > On Wed, May 13, 2020 at 03:06:35PM -0700, Ian Rogers wrote: > > SNIP > > > found event unc_iio_data_req_of_cpu.mem_read.part3 > > adding {unc_iio_data_req_of_cpu.mem_read.part0,unc_iio_data_req_of_cpu.mem_read.part1,unc_iio_data_req_of_cpu.mem_read.part2,unc_iio_data_req_of_cpu.mem_read.part3}:W,{unc_iio_data_req_of_cpu.mem_read.part0,unc_iio_data_req_of_cpu.mem_read.part1,unc_iio_data_req_of_cpu.mem_read.part2,unc_iio_data_req_of_cpu.mem_read.part3}:W > > intel_pt default config: tsc,mtc,mtc_period=3,psb_period=3,pt,branch > > Attempting to add event pmu 'uncore_iio_free_running_5' with 'unc_iio_data_req_of_cpu.mem_read.part0,' that may result in non-fatal errors > > After aliases, add event pmu 'uncore_iio_free_running_5' with 'fc_mask,ch_mask,umask,event,' that may result in non-fatal errors > > Attempting to add event pmu 'uncore_iio_free_running_3' with 'unc_iio_data_req_of_cpu.mem_read.part0,' that may result in non-fatal errors > > After aliases, add event pmu 'uncore_iio_free_running_3' with 'fc_mask,ch_mask,umask,event,' that may result in non-fatal errors > > Attempting to add event pmu 'uncore_iio_free_running_1' with 'unc_iio_data_req_of_cpu.mem_read.part0,' that may result in non-fatal errors > > After aliases, add event pmu 'uncore_iio_free_running_1' with 'fc_mask,ch_mask,umask,event,' that may result in non-fatal errors > > Multiple errors dropping message: unknown term 'fc_mask' for pmu 'uncore_iio_free_running_3' (valid terms: event,umask,config,config1,config2,name,period,percore) > > ... > > > > So before you see a 'WARNING: multiple event parsing errors' and > > 'Invalid event/parameter'. After you see 'Attempting... that may result > > in non-fatal errors' then 'Multiple errors...' with details that > > 'fc_mask' wasn't known to a free running counter. While not completely > > clean, this makes it clearer that an error hasn't really occurred. > > > > v2. addresses review feedback from Jiri Olsa <jolsa@redhat.com>. > > > > Reviewed-by: Andi Kleen <ak@linux.intel.com> > > Acked-by: Jiri Olsa <jolsa@redhat.com>
Thanks, applied.
- Arnaldo
| |