Messages in this thread | | | From | dillon min <> | Date | Thu, 14 May 2020 17:17:42 +0800 | Subject | Re: [PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board |
| |
Hi, Linus,
thanks for reviewing.
On Thu, May 14, 2020 at 4:24 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Tue, May 12, 2020 at 9:04 AM <dillon.minfei@gmail.com> wrote: > > > From: dillon min <dillon.minfei@gmail.com> > > > > Enable the ltdc & ili9341 on stm32429-disco board. > > > > Signed-off-by: dillon min <dillon.minfei@gmail.com> > > This mostly looks good but... > > > +&spi5 { > > + status = "okay"; > > + pinctrl-0 = <&spi5_pins>; > > + pinctrl-names = "default"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; > > + dmas = <&dma2 3 2 0x400 0x0>, > > + <&dma2 4 2 0x400 0x0>; > > + dma-names = "rx", "tx"; > > These DMA assignments seem to be SoC things and should > rather be in the DTS(I) file where &spi5 is defined, right? > stm32f429.dtsi I suppose? > > It is likely the same no matter which device is using spi5. > > Yours, > Linus Walleij
Yes, the dma assignments can be moved to stm32f429.dtsi file. i will change it.
thanks.
best regards.
dillon,
| |