lkml.org 
[lkml]   [2020]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 62/90] ceph: fix endianness bug when handling MDS session feature bits
    Date
    From: Jeff Layton <jlayton@kernel.org>

    commit 0fa8263367db9287aa0632f96c1a5f93cc478150 upstream.

    Eduard reported a problem mounting cephfs on s390 arch. The feature
    mask sent by the MDS is little-endian, so we need to convert it
    before storing and testing against it.

    Cc: stable@vger.kernel.org
    Reported-and-Tested-by: Eduard Shishkin <edward6@linux.ibm.com>
    Signed-off-by: Jeff Layton <jlayton@kernel.org>
    Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
    Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ceph/mds_client.c | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    --- a/fs/ceph/mds_client.c
    +++ b/fs/ceph/mds_client.c
    @@ -3072,8 +3072,7 @@ static void handle_session(struct ceph_m
    void *end = p + msg->front.iov_len;
    struct ceph_mds_session_head *h;
    u32 op;
    - u64 seq;
    - unsigned long features = 0;
    + u64 seq, features = 0;
    int wake = 0;
    bool blacklisted = false;

    @@ -3092,9 +3091,8 @@ static void handle_session(struct ceph_m
    goto bad;
    /* version >= 3, feature bits */
    ceph_decode_32_safe(&p, end, len, bad);
    - ceph_decode_need(&p, end, len, bad);
    - memcpy(&features, p, min_t(size_t, len, sizeof(features)));
    - p += len;
    + ceph_decode_64_safe(&p, end, features, bad);
    + p += len - sizeof(features);
    }

    mutex_lock(&mdsc->mutex);

    \
     
     \ /
      Last update: 2020-05-13 12:03    [W:4.083 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site