lkml.org 
[lkml]   [2020]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 26/90] nfp: abm: fix a memory leak bug
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit bd4af432cc71b5fbfe4833510359a6ad3ada250d ]

    In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open.
    But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released,
    which can lead to a memory leak bug. Fix this issue by adding
    nfp_nsp_close(nsp) in the error path.

    Fixes: f6e71efdf9fb1 ("nfp: abm: look up MAC addresses via management FW")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Acked-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/netronome/nfp/abm/main.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/ethernet/netronome/nfp/abm/main.c
    +++ b/drivers/net/ethernet/netronome/nfp/abm/main.c
    @@ -283,6 +283,7 @@ nfp_abm_vnic_set_mac(struct nfp_pf *pf,
    if (!nfp_nsp_has_hwinfo_lookup(nsp)) {
    nfp_warn(pf->cpp, "NSP doesn't support PF MAC generation\n");
    eth_hw_addr_random(nn->dp.netdev);
    + nfp_nsp_close(nsp);
    return;
    }


    \
     
     \ /
      Last update: 2020-05-13 11:50    [W:4.142 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site