lkml.org 
[lkml]   [2020]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] char: ipmi: convert to use i2c_new_client_device()

> > - addr_info->added_client = i2c_new_device(to_i2c_adapter(adev),
> > - &addr_info->binfo);
> > + addr_info->added_client = i2c_new_client_device(to_i2c_adapter(adev),
> > + &addr_info->binfo);
>
> i2c_new_client_device returns an ERR_PTR, not NULL on error. So this

Yes, this is the main motivation for the new API.

> needs some more work. I'll send something out soon.

Why does it need that work? 'added_client' is only used with
i2c_unregister_device() which has been fixed to handle ERR_PTR as well.
Or am I missing something?

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-05-13 09:10    [W:0.126 / U:4.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site