Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] keys: Make the KEY_NEED_* perms an enum rather than a mask | Date | Thu, 14 May 2020 00:16:12 +0100 |
| |
Paul Moore <paul@paul-moore.com> wrote:
> > + case KEY_NEED_VIEW: perm = KEY__VIEW; break; > > + case KEY_NEED_READ: perm = KEY__READ; break; > > + case KEY_NEED_WRITE: perm = KEY__WRITE; break; > > + case KEY_NEED_SEARCH: perm = KEY__SEARCH; break; > > + case KEY_NEED_LINK: perm = KEY__LINK; break; > > + case KEY_NEED_SETATTR: perm = KEY__SETATTR; break; > > Please don't put the case statements all on one line, use the more > traditional multi-line format. For example: > > case KEY_NEED_SETATTR: > perm = KEY__SETATTR; > break;
Tabulation was invented something like 6000 years ago for just this kind of purpose;-) It's less readable your way, but whatever...
David
| |