lkml.org 
[lkml]   [2020]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: remove a few uses of ->queuedata
    On Tue, May 12, 2020 at 1:08 AM Christoph Hellwig <hch@lst.de> wrote:
    >
    > On Sat, May 09, 2020 at 08:07:14AM -0700, Dan Williams wrote:
    > > > which are all used in the I/O submission path (generic_make_request /
    > > > generic_make_request_checks). This is mostly a prep cleanup patch to
    > > > also remove the pointless queue argument from ->make_request - then
    > > > ->queue is an extra dereference and extra churn.
    > >
    > > Ah ok. If the changelogs had been filled in with something like "In
    > > preparation for removing @q from make_request_fn, stop using
    > > ->queuedata", I probably wouldn't have looked twice.
    > >
    > > For the nvdimm/ driver updates you can add:
    > >
    > > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
    > >
    > > ...or just let me know if you want me to pick those up through the nvdimm tree.
    >
    > I'd love you to pick them up through the nvdimm tree. Do you want
    > to fix up the commit message yourself?

    Will do, thanks.

    \
     
     \ /
      Last update: 2020-05-14 00:27    [W:4.682 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site