Messages in this thread | | | From | Ian Rogers <> | Date | Wed, 13 May 2020 14:03:56 -0700 | Subject | Re: [PATCH] perf tools: Replace zero-length array with flexible-array |
| |
On Tue, May 12, 2020 at 10:59 AM Gustavo A. R. Silva <gustavoars@kernel.org> wrote: > > On Tue, May 12, 2020 at 10:06:07AM +0200, Peter Zijlstra wrote: > > On Mon, May 11, 2020 at 07:04:04PM -0500, Gustavo A. R. Silva wrote: > > > On Mon, May 11, 2020 at 05:20:08PM -0300, Arnaldo Melo wrote: > > > > > > > > Thanks, applied > > > > > > > > > > Thanks, Arnaldo. > > > > > > I wonder if could also take the other two: > > > > > > https://lore.kernel.org/lkml/20200511200911.GA13149@embeddedor/ > > > https://lore.kernel.org/lkml/20200511201227.GA14041@embeddedor/ > > > > I think I have those, but let me make sure. > > Great. :)
Thanks for the cleanup! It has yielded a clang compiler warning/error for me in kernel/git/acme/linux.git branch perf/core:
util/intel-pt.c:1802:24: error: field 'br_stack' with variable sized type 'struct branch_stack' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end] struct branch_stack br_stack;
I think this can be resolved by reordering the members of the struct, and may have been a latent bug exposed by this change. It's unfortunate it has broken this build.
Thanks, Ian
> Thanks > -- > Gustavo >
| |