Messages in this thread | | | From | Brian Norris <> | Date | Tue, 12 May 2020 09:56:47 -0700 | Subject | Re: [PATCH] ath9k: release allocated buffer if timed out |
| |
On Fri, Sep 6, 2019 at 11:59 AM Navid Emamdoost <navid.emamdoost@gmail.com> wrote: > > In ath9k_wmi_cmd, the allocated network buffer needs to be released > if timeout happens. Otherwise memory will be leaked. > > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
I wonder, did you actually test your patches? I ask, because it seems that all your patches are of the same mechanical variety (produced by some sort of research project?), and if I look around a bit, I see several mistakes and regressions noted on your other patches. And recently, I see someone reporting a 5.4 kernel regression, which looks a lot like it was caused by this patch:
https://bugzilla.kernel.org/show_bug.cgi?id=207703#c1
I'll propose a revert, if there's no evidence this was actually tested or otherwise confirmed to fix a real bug.
Brian
| |